Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(axe-core 4.9.1): Axe core version upgrade for Web #7369

Merged
merged 7 commits into from
Jun 20, 2024

Conversation

rohittarpara
Copy link
Contributor

Details

This PR updates axe-core to its latest version, 4.9.1, from 4.8.4. It also bumps the accessibility-insights-report package version.

See also Minor version upgrade 4.9.0 release notes

Motivation

Part of Feature 2187203 (internal access required to view).

Context

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@rohittarpara rohittarpara requested a review from a team as a code owner June 19, 2024 09:28
@v-viyada v-viyada marked this pull request as draft June 19, 2024 13:50
@v-viyada v-viyada marked this pull request as ready for review June 20, 2024 18:44
Copy link
Contributor

@codeofdusk codeofdusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending updates to report package version as done in abandoned #7357. CI failure is unrelated, see #7323.

packages/ui/package.json Show resolved Hide resolved
Fluentui/react will be updated in a follow-up.

This reverts commit 5795386.
@codeofdusk codeofdusk merged commit e37dee6 into microsoft:main Jun 20, 2024
12 of 13 checks passed
madalynrose added a commit that referenced this pull request Jul 23, 2024
#### Details

This PR enables the changelog script to output a .txt file with a list
of commits to validate instead of a .csv.

This can be triggered by adding a flag onto the end of the script for
the desired kind of file:

`node ./tools/get-change-log-for-release.js --from web@PREVIOUS_RELEASE
--to web@NEW_RELEASE --kind txt`
or
`yarn run change-log --from web@PREVIOUS_RELEASE --to web@NEW_RELEASE -k
txt`

Example Output:

This is the result for running `yarn run change-log -f [email protected] -t
[email protected] -k txt`

```
[tester]
        dev: Chirag Sharma
        pr: #7378
        group: fix
        change: fix: adding code to format nextline character (\r\n) (#7378)
[tester]
        dev: rohittarpara
        pr: #7377
        group: fix
        change: fix: <hx role="none"> is reported as heading. (#7377)
[tester]
        dev: rohittarpara
        pr: #7374
        group: chore
        change: chore: update @fluentui/react from 8.96.1 to 8.118.1 (#7374)
[tester]
        dev: rohittarpara
        pr: #7369
        group: feat(axe-core 4.9.1)
        change: feat(axe-core 4.9.1): Axe core version upgrade for Web (#7369)
[tester]
        dev: Chirag Sharma
        pr: #7370
        group: chore
        change: chore : Update package version for accessibility insights report and accessibility insights ui (#7370)
```

The release driver would just need to paste this into OneNote, remove
any commits that are non-user-facing, and format like a list to add
bullets and the indents are already there!

##### Motivation

Our changelog script generates a csv of the commits to main between two
commits (usually the previous release and HEAD). During release
validation, our team filters down that CSV in excel and then pastes the
generated table into our validation template so we can check that those
commits have successfully made it into the new release. To make our
release validation process more accessible, we are moving away from
using tables in our validation templates.

##### Context

The text version of the changelog automatically excludes `dependabot`
and `chore(deps-dev)` commits, as it is more cumbersome to filter the
text list than the csv and these updates aren't included in validation
anyhow.

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [n/a] Addresses an existing issue: #0000
- [x] Ran `yarn fastpass`
- [n/a] Added/updated relevant unit test(s) (and ran `yarn test`)
- [n/a] Verified code coverage for the changes made. Check coverage
report at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [n/a] (UI changes only) Added screenshots/GIFs to description above
- [n/a] (UI changes only) Verified usability with NVDA/JAWS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants